[docs] Document how to unmount transition child #30382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a828f79 to
cef4047
Compare
mnajdova
reviewed
Dec 24, 2021
| @@ -308,7 +308,7 @@ export default function AppLayoutDocsFooter() { | |||
| </PaginationDiv> | |||
| </React.Fragment> | |||
| )} | |||
| <Collapse in={commentOpen} onEntered={handleEntered}> | |||
| <Collapse in={commentOpen} unmountOnExit onEntered={handleEntered}> | |||
There was a problem hiding this comment.
I would extract this to a separate PR, but probably not worth the effort :D
There was a problem hiding this comment.
I see what you mean. What's the main value proposition of this PR? To be fair, I think that the WAVE error is wrong and should be ignored, the input is not interactive. I think that the real value of this prop is about reducing the upfront work to render the page, so aligned with the docs, it illustrates the use case with a real life win.
This win:
is a good side effect. But if you go to https://mui.com/components/textarea-autosize/, you will still see the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed this having a quick look at #30378. When you open WAVE, on any page, say https://mui.com/components/alert/, it will let you know that
the textbox in the rating popup is missing a text label. But why is this rendered in the DOM in the first place?
So, I'm removing it from the DOM with the prop. It should help with performance, only rendering what's needed.
Second, since this is kind of an obscure trick and I saw people asking about it 1-2 years ago on the issue, and that it's still not in the docs, I added it. https://deploy-preview-30382--material-ui.netlify.app/components/transitions/#performance-amp-seo