Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Support sx prop of function type in extendSxProp() #29284

Closed
wants to merge 1 commit into from
Closed

[system] Support sx prop of function type in extendSxProp() #29284

wants to merge 1 commit into from

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Oct 25, 2021

Continuation of #29198

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 25, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against e354259

@siriwatknp
Copy link
Member

siriwatknp commented Oct 26, 2021 •
edited
Loading

@hbjORbj Sorry for the late notice. I think this PR can be closed in favor of #29297 (it touch the same function anyway) to not have merge conflict.

@hbjORbj
Copy link
Member Author

hbjORbj commented Oct 27, 2021

@hbjORbj Sorry for the late notice. I think this PR can be closed in favor of #29297 (it touch the same function anyway) to not have merge conflict.

@siriwatknp #29297 doesn't touch on extendSxProp() though? This PR is much smaller so isn't it better that I merge this and you merge that PR after resolving conflicts?

@siriwatknp
Copy link
Member

@hbjORbj Sorry for the late notice. I think this PR can be closed in favor of #29297 (it touch the same function anyway) to not have merge conflict.

@siriwatknp #29297 doesn't touch on extendSxProp() though? This PR is much smaller so isn't it better that I merge this and you merge that PR after resolving conflicts?

My PR touches that file.
image

@hbjORbj hbjORbj closed this Oct 27, 2021
@zannager zannager added the package: system Specific to @mui/system label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hbjORbj @mui-pr-bot @siriwatknp @zannager