Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Recommend yarn t over test:watch #28254

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 10, 2021

yarn test:watch is really not suitable for 99% of the use cases. The one-off tasks can use yarn test:unit --watch.

Also removes the --inspect-brk flag from the experimental CLI since it's not straight forward to use. If you need it, and know what you're doing, you're better off editing the CLI locally.

@eps1lon eps1lon added the test label Sep 10, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 10, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 6cd8136

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I always use the yarn t <test>

@eps1lon eps1lon changed the base branch from next to master September 14, 2021 08:08
@eps1lon eps1lon merged commit 8173909 into mui:master Sep 14, 2021
@eps1lon eps1lon deleted the test/inspect-brk branch September 14, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants