Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update docs for Icon Button #2700

Merged
merged 1 commit into from
Dec 30, 2015

Conversation

Zadielerick
Copy link
Contributor

No description provided.

@Zadielerick Zadielerick changed the title Update docs for Icon Button [Docs] Update docs for Icon Button Dec 29, 2015
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 29, 2015
import FontIcon from 'material-ui/lib/font-icon';
import IconButton from 'material-ui/lib/icon-button';

const IconButtonExampleSimple = () => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IconButtonExampleMaterial

@Zadielerick Zadielerick force-pushed the iconButtonDocsUpdate branch 2 times, most recently from a394789 to 3587a21 Compare December 29, 2015 22:27
@oliviertassinari
Copy link
Member

@Zadielerick It looks good 👍. Can you squash down?

@@ -92,7 +92,7 @@ const AppRoutes = (
<Route path="dropdown-menu" component={DropDownMenuPage} />
<Route path="grid-list" component={GridListPage} />
<Route path="icons" component={Icons} />
<Route path="icon-buttons" component={IconButtons} />
<Route path="icon-buttons" component={IconButtonPage} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"icon-button"? We have to update the leftnav bar too.

@@ -187,7 +187,7 @@ const AppLeftNav = React.createClass({
primaryText="Icons"
/>,
<ListItem
value="/components/icon-buttons"
value="/components/icon-button"
primaryText="Icon Buttons"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon Button 😁

oliviertassinari added a commit that referenced this pull request Dec 30, 2015
@oliviertassinari oliviertassinari merged commit 82163ee into mui:master Dec 30, 2015
@oliviertassinari
Copy link
Member

@Zadielerick Yeah, one more, great job 👍

@Zadielerick Zadielerick deleted the iconButtonDocsUpdate branch December 30, 2015 21:36
@alitaheri
Copy link
Member

@Zadielerick Awesome job 👍 👍 👍 you've been a huge help ^_^

@Zadielerick
Copy link
Contributor Author

No problem! Hope I can finish all the components by next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants