[docs] Migrate onepirate premium template to emotion part1 #26671
Conversation
| marginTop: theme.spacing(8), | ||
| }, | ||
| } as const); | ||
| const item: SxProps<Theme> = { |
There was a problem hiding this comment.
SxProps<Theme> Sometimes it is necessary and sometimes it is not. I feel confused why this is happening.
There was a problem hiding this comment.
Interesting, if fails with flexDirection: 'column',.
There was a problem hiding this comment.
I'll create an issue, so that I don't forget to look into it.
| }, | ||
| sizeSmall: { | ||
| ...(size === 'small' && { |
There was a problem hiding this comment.
While this works ... when inspecting the element the class that it will always assign is MuiButton-sizeMedium. It causes me a little noise, shouldn't it be something else?
The same happens for large
There was a problem hiding this comment.
Fixed in vicasas#1, if you merge it.
There was a problem hiding this comment.
Thanks @oliviertassinari. Should we stop using this? shouldForwardProp: (prop) => prop! == 'size', why did I understand this was to not pass the property to the DOM element? They correct me if I'm wrong.
There was a problem hiding this comment.
Oops! I just saw that size is a Button prop 😅
| marginTop: theme.spacing(8), | ||
| }, | ||
| } as const); | ||
| const item: SxProps<Theme> = { |
There was a problem hiding this comment.
Interesting, if fails with flexDirection: 'column',.
* better to forward the size * add context
This is a first part of the migration
One of #16947
https://deploy-preview-26671--material-ui.netlify.app/premium-themes/onepirate/