[docs] Migrate to emotion landing (part1) #26498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliviertassinari Should there be the spotify logo in the Users section? as is currently in v4 |
|
It's true! I did not remember. I'll close the PR. |
|
@vicasas But feel free to migrate the other parts of the projects. This instance seems to be an exception |
|
I have updated #16947 with the last usage of makeStyles/withStyles I could identify as making sense to replace. |
|
@oliviertassinari That's great! I will try to focus on those during these days. Thanks. |
| key={user.caption} | ||
| src={`/static/images/users/${user.logo}`} | ||
| alt={user.caption} | ||
| className={clsx(classes.img, classes[user.class])} | ||
| sx={{ my: 1.5, mx: 3, ...styles[user.class] }} |
There was a problem hiding this comment.
in this case can we add this library @emotion/css and
Sample code
import { cx, css } from '@emotion/css'
const cls1 = css`
font-size: 20px;
background: green;
`
const cls2 = css`
font-size: 20px;
background: blue;
`
<div className={cx(cls1, cls2)} />
@oliviertassinari
emotion provide number library which can useful for styling or in latest material ui provide will those option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to emotion the sections Pro, QuickWord, Quotes and Users
Related #16947