[docs] Migrate Autocomplete demos #26127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 tasks
mnajdova
commented
May 5, 2021
| @@ -1,110 +1,28 @@ | |||
| /* eslint-disable @typescript-eslint/no-use-before-define */ | |||
| import * as React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import { useTheme, makeStyles } from '@material-ui/core/styles'; | |||
| import { useTheme, experimentalStyled as styled } from '@material-ui/core/styles'; | |||
There was a problem hiding this comment.
@vicasas @oliviertassinari would be great to have another one look into the changes on this demo too. It was a bit challenging to follow what should go where.
oliviertassinari
approved these changes
May 5, 2021
There was a problem hiding this comment.
I went a couple of step further
- Fix dark mode issues
- Use sx over style
- Use Stack over ad-hoc solution, a continuation of [docs] Polish the pickers demo #26094 (comment)
|
Actually, I like how unstyled components are using the CSS template string, and customization on the core component the JS Object syntax. It looks like a great call |
vicasas
suggested changes
May 5, 2021
docs/src/pages/components/autocomplete/CustomInputAutocomplete.tsx
Outdated
Show resolved
Hide resolved
vicasas
previously requested changes
May 5, 2021
….tsx Co-authored-by: Víctor Casas <57921784+vicasas@users.noreply.github.com>
vicasas
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates
Autocompletedemos to emotion. One of #16947Preview: https://deploy-preview-26127--material-ui.netlify.app/components/autocomplete/