Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate TextField demos to emotion #25626

Merged
merged 28 commits into from
Apr 12, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Apr 5, 2021

Related to #16947

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 5, 2021

No bundle size changes

Generated by 🚫 dangerJS against 28a97f3

@vicasas
Copy link
Member Author

vicasas commented Apr 5, 2021

Failure of argos is for visuals corrections.

@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Apr 5, 2021
docs/src/pages/components/text-fields/ColorTextFields.js Outdated Show resolved Hide resolved
<Box
sx={{
'& > :not(style)': {
m: 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
m: 1,
display: 'flex',
alignItems: 'center',

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as explained here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does :not(style) mean?

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the current demos could be broken down. There is a lot of content to scroll, probably too much, but it's a different topic.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnajdova mnajdova merged commit 85d2a51 into mui:next Apr 12, 2021
@vicasas vicasas deleted the feature/migrate-textfield-demo-to-emotion branch April 12, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants