Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate Radio demos to emotion #25396

Merged

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Mar 17, 2021

The following demos of the Radio component were migrated:

  • Error radio
  • Customized radio
  • useRadioGroup

Related to #16947

@vicasas
Copy link
Member Author

vicasas commented Mar 17, 2021

@oliviertassinari Is it correct to do this for styles that make sense? Is there another way?

const StyledFormControlLabel = styled((props: StyledFormControlLabelProps) => (
  <FormControlLabel {...props} />
))(({ theme, checked }) => ({
  '.MuiFormControlLabel-label': checked && {
    color: theme.palette.secondary.main,
  },
}));

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 17, 2021

No bundle size changes

Generated by 🚫 dangerJS against efc04ca

@vicasas
Copy link
Member Author

vicasas commented Mar 17, 2021

This failed for timeout. Run again CI please.

@oliviertassinari oliviertassinari added component: radio This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Mar 17, 2021
@oliviertassinari oliviertassinari force-pushed the feature/migrate-radio-demo-to-emotion branch from 4206e6d to 05175c6 Compare March 18, 2021 00:20
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari oliviertassinari merged commit 5fb2a24 into mui:next Mar 18, 2021
@oliviertassinari
Copy link
Member

I have used the fix of the checkbox PR and applied it here. We are good :)

@vicasas
Copy link
Member Author

vicasas commented Mar 18, 2021

@oliviertassinari I could not replicate it here, my day was full. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: radio This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants