Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate Avatar demos to emotion #25375

Merged

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Mar 15, 2021

The following demos of the Avatar component were migrated:

  • Image avatar
  • Letter avatar
  • Size avatar
  • Icon avatar
  • Variant avatar
  • Fallbacks avatar
  • With badge + demo

Related to #16947

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 15, 2021

No bundle size changes

Generated by 🚫 dangerJS against 0012b79

@vicasas
Copy link
Member Author

vicasas commented Mar 15, 2021

I think the keyframe of the demo whit badge is not working, I will check it later

@tomasznguyen
Copy link
Contributor

Hi @vicasas . I just see now that you also migrated the avatar demos to emotion. I have not seen that, sorry. Next time I'll let you know if I start working on a demo.

Regarding the keyframe. I struggled with that as well. If you replace $ripple by just ripple, then the animation will work fine.

@vicasas
Copy link
Member Author

vicasas commented Mar 16, 2021

You're right! I didn't see $ripple. I'll try it later. Thanks.

@oliviertassinari oliviertassinari merged commit c50f000 into mui:next Mar 18, 2021
@zannager zannager added docs Improvements or additions to the documentation component: avatar This is the name of the generic UI component, not the React module! labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: avatar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants