Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Migrate Switch demos to emotion #25366

Merged
merged 8 commits into from
Mar 21, 2021
Merged

[docs] Migrate Switch demos to emotion #25366

merged 8 commits into from
Mar 21, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Mar 14, 2021

The following demos of the Switch component were migrated:

  • Customized switches

Related to #16947

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 14, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 340d4c8

@vicasas
Copy link
Member Author

vicasas commented Mar 14, 2021

focusVisibleClassName It is not declared in the Switch API. Is it obsolete or not used now?

<Switch
    // focusVisibleClassName={classes.focusVisible}
    disableRipple
    {...props}
/>

@vicasas vicasas mentioned this pull request Mar 14, 2021
Closed
89 tasks
@oliviertassinari oliviertassinari added component: switch This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Mar 14, 2021
@oliviertassinari
Copy link
Member

@vicasas focusVisibleClassName is still relevant. It flows like this Switch > SwitchBase > IconButton > ButtonBase. It's used for this UI state:

Screenshot 2021-03-14 at 21 38 56

@vicasas vicasas changed the title [docs] Migrate Switch to emotion [docs] Migrate Switch demo to emotion Mar 14, 2021
@vicasas vicasas changed the title [docs] Migrate Switch demo to emotion [docs] Migrate Switch demos to emotion Mar 14, 2021
@vicasas
Copy link
Member Author

vicasas commented Mar 14, 2021

focusVisibleClassName is still relevant.

@oliviertassinari How would this be used from props you can unstructured to get to styles?

@oliviertassinari
Copy link
Member

@vicasas The simplest is to use .Mui-focusVisible directly.

@vicasas
Copy link
Member Author

vicasas commented Mar 15, 2021 •
edited
Loading

The simplest is to use .Mui-focusVisible directly.

@oliviertassinari It's done, but I don't see the visual difference

image

@github-actions github-actions bot mentioned this pull request Mar 15, 2021
Closed
@oliviertassinari oliviertassinari force-pushed the feature/migrate-switch-demo-to-emotion branch from 81b245f to 2c98f6b Compare March 21, 2021 15:10
@oliviertassinari oliviertassinari merged commit f60e7bd into mui:next Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: switch This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicasas @mui-pr-bot @oliviertassinari