Update theme-manager.js #2527
Update theme-manager.js #2527
Conversation
Add function to modify the zIndex of the raw theme
| @@ -252,5 +252,13 @@ export default { | |||
| let newRawTheme = update(muiTheme.rawTheme, {fontFamily: {$set: newFontFamily}}); | |||
| return this.getMuiTheme(newRawTheme); | |||
| }, | |||
|
|
|||
| //function to modify the zIndex of the raw theme. This function recomputes | |||
There was a problem hiding this comment.
you have trailing spaces here
|
Good feature, thanks a lot 👍 🎉 . Also, please add this to the documentation here as well. |
add modifyRawThemeZIndices
| @@ -252,5 +252,13 @@ export default { | |||
| let newRawTheme = update(muiTheme.rawTheme, {fontFamily: {$set: newFontFamily}}); | |||
| return this.getMuiTheme(newRawTheme); | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
the space seems to be here. It's failing the build.
|
Please wait a little before fixing that |
|
I want to hear @oliviertassinari's insight on this. maybe |
|
@subjectix I guess it's time that I implement the solution I have proposed here #2460. |
rename modifyRawThemeZIndices to modifyRawThemeZIndex
|
@oliviertassinari Hmmmm, you might be right. But these are only helper methods. and we should keep them around for a while. I'd say let's merge this and keep these functions around for a little while before we do a full rewrite and deprecate them all together. |
Sounds like a plan. |
|
@oliviertassinari Thanks 👍 👍 @woshiwenzhijie Squash down your commits and we'll merge this. 👍 👍 |
|
😁 |
|
@woshiwenzhijie As it's your first contribution, I'm gonna merge this PR even those we prefer to have a single commit to have a cleaner history. |
[Theme] Update theme-manager.js
|
@woshiwenzhijie Thanks 👍 🎉 |
Add function to modify the zIndex of the raw theme