Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate Fab demos to emotion #25251

Merged

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Mar 7, 2021

The following demos of the Fab component were migrated:

  • Basic fab
  • Sizes fab
  • Animation fab

Related to #16947

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 7, 2021

No bundle size changes

Generated by 🚫 dangerJS against 7af1e5f

@oliviertassinari oliviertassinari added component: Fab The React component. docs Improvements or additions to the documentation labels Mar 7, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have spent 10 minutes pushing it further. You can review each individual commit.

@vicasas
Copy link
Member Author

vicasas commented Mar 7, 2021

@oliviertassinari Thanks for all the feedback, I read each one of them and I will try to make the demos smaller. He did not know what made the code to be seen or hidden, now I understand that it depends on the length of the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Fab The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants