Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Improve typescript-to-proptypes test suite #25209

Merged
merged 3 commits into from
Mar 6, 2021
Merged

[test] Improve typescript-to-proptypes test suite #25209

merged 3 commits into from
Mar 6, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 5, 2021

rename score too low means git doesn't detect it as renamed :(

  1. dynamic require() -> await import()
  2. specific filename to be able to run with yarn t typescript-to-proptypes
  3. Lazily init the TS program (saving around 200-300ms startup time if you're not running the ttp tests)
  4. Init prettier config correctly (needs to be resolved per file)
  5. wrap in describe() block for grep
  6. .forEach instead of for-of (one less noisy eslint-disable)

@eps1lon eps1lon added the test label Mar 5, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 5, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 610be75

@eps1lon eps1lon marked this pull request as ready for review March 5, 2021 14:28
@github-actions github-actions bot mentioned this pull request Mar 5, 2021
Closed
@eps1lon eps1lon merged commit 69c2084 into mui:next Mar 6, 2021
@eps1lon eps1lon deleted the test/ttp-modern branch March 6, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eps1lon @mui-pr-bot