[docs] Add GlobalStyles API #25191
Merged
[docs] Add GlobalStyles API #25191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1b2e33 to
458b278
Compare
eps1lon
commented
Mar 4, 2021
Comment on lines
+18
to
+27
| styles: PropTypes.oneOfType([ | ||
| PropTypes.func, | ||
| PropTypes.number, | ||
| PropTypes.object, | ||
| PropTypes.shape({ | ||
| __emotion_styles: PropTypes.any.isRequired, | ||
| }), | ||
| PropTypes.string, | ||
| PropTypes.bool, | ||
| ]), |
There was a problem hiding this comment.
The follow-up in the PR description should address this.
oliviertassinari
approved these changes
Mar 4, 2021
| @@ -1,3 +1,7 @@ | |||
| --- | |||
| components: GlobalStyles | |||
There was a problem hiding this comment.
Haha, smart, I actually wonder if you would have gone this far
There was a problem hiding this comment.
I don't follow. That's what we do for every component?
I'm actually planning to warn/throw if a component has no demos mentioned.
There was a problem hiding this comment.
True, I'm simply glad you thought to add it here. I forgot this when I first review the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up:
stylestype is likely too wide right now e.g. what is<GlobalStyles styles={false} />supposed to do?