Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Migrate Divider demos to emotion #25145

Merged
merged 12 commits into from
Mar 2, 2021
Merged

[docs] Migrate Divider demos to emotion #25145

merged 12 commits into from
Mar 2, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Feb 28, 2021

The following demos of the Button component were migrated:

  • List dividers
  • Inset dividers
  • Subheader dividers
  • Middle dividers
  • Vertical dividers

Related to #16947

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 28, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 808f450

@vicasas
Copy link
Member Author

vicasas commented Feb 28, 2021 •
edited
Loading

@oliviertassinari I still have to migrate the following demos, but first I have some doubts

  • Vertical with text
  • Dividers with text
  1. How can I do this without problems? ...(theme) => ...theme.typography.body2 in the sx props
  2. In the Vertical divider demo I went from 4px to 16px using theme.shape.borderRadius. Do we leave it like that or do I place 4px direct?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 28, 2021
oliviertassinari
oliviertassinari requested changes Feb 28, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look, we can apply the same comments multiple times

@vicasas
Copy link
Member Author

vicasas commented Feb 28, 2021

@oliviertassinari Thanks for the comments, I'll check them later. I continue with the question of point 1 that I comment above.

@oliviertassinari
Copy link
Member

  1. https://next.material-ui.com/system/typography/#variant
  2. https://next.material-ui.com/system/borders/#border-radius

oliviertassinari
oliviertassinari approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed an update to further shorthen the demos

@oliviertassinari oliviertassinari merged commit 4b2661d into mui:next Mar 2, 2021
@oliviertassinari
Copy link
Member

Thanks

@github-actions github-actions bot mentioned this pull request Mar 2, 2021
Closed
@vicasas
Copy link
Member Author

vicasas commented Mar 2, 2021 •
edited
Loading

thanks to you, it was a pleasure 😁

@github-actions github-actions bot mentioned this pull request Mar 2, 2021
Closed
@vicasas vicasas mentioned this pull request Mar 14, 2021
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicasas @mui-pr-bot @oliviertassinari