[zIndex] Add a common index #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dialog: 13, | ||
| layer: 20, | ||
| popover: 20, | ||
| }; |
There was a problem hiding this comment.
That's the most important part.
That's what boostrap is using:
@zindex-navbar: 1000;
@zindex-dropdown: 1000;
@zindex-navbar-fixed: 1030;
@zindex-modal-background: 1040;
@zindex-modal: 1050;
@zindex-popover: 1060;
@zindex-tooltip: 1070;(https://github.com/twbs/bootstrap/blob/master/less/variables.less#L272)
There was a problem hiding this comment.
we definately need tooltip too. add it for now, we can fix #210 and related issues with this
| let styles = { | ||
| root: { | ||
| position: 'fixed', | ||
| height: '100%', | ||
| width: '100%', | ||
| zIndex: 9, | ||
| zIndex: rawTheme.zIndex.dialog - 1, |
There was a problem hiding this comment.
I think it's better to have dialogOverlay and leftNavOverlay too. dialog - 1 = leftnav. that means it's possible that dialog's overlay might not cover leftnav's in some cases, which is undesirable
|
@subjectix Are you ok with this? |
|
@oliviertassinari It's very good, Thanks a lot :+1 👍 |
oliviertassinari
added a commit
that referenced
this pull request
Dec 10, 2015
[zIndex] Add a common index
| layer: 2000, | ||
| popover: 2100, | ||
| tooltip: 3000, | ||
| }; |
There was a problem hiding this comment.
here is the index.
|
awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's good to notice that boostrap is using the following values:
(https://github.com/twbs/bootstrap/blob/master/less/variables.less#L272)