Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] convertLength does not work for fromUnit !== 'px' #22739

Merged
merged 1 commit into from
Sep 25, 2020
Merged

[theme] convertLength does not work for fromUnit !== 'px' #22739

merged 1 commit into from
Sep 25, 2020

Conversation

brorlarsnicklas
Copy link
Contributor

Closes #22693

@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 6d12bc1

@oliviertassinari oliviertassinari changed the title convertLength does not work for fromUnit !== 'px' [theme] convertLength does not work for fromUnit !== 'px' Sep 25, 2020
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Sep 25, 2020
@oliviertassinari oliviertassinari merged commit 2587f77 into mui:next Sep 25, 2020
@oliviertassinari
Copy link
Member

@brorlarsnicklas It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convertLength does not work for fromUnit !== 'px'
3 participants
@brorlarsnicklas @mui-pr-bot @oliviertassinari