[Rating] Treat read-only as image #22639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
412b8ea to
821a92b
Compare
oliviertassinari
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Nice, I didn't know readonly wasn't supported by radio too. I did a quick search to understand why, I could land on w3c/html#92, the topic seems controversial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts behavior introduced by #22606. Since native radios/checkboxes don't support readonly either (as well as our Radio/Checkbox component) we should work on this with a more holistic approach based off of real-world use cases. See #17043.
Reworked the test suite based on the fact that
nameis optional and codified current behavior of<Rating readOnly />in tests.