[Rating] Simpler customization of active "no value" styles #22613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Customization of pristine label
Preliminary change which isn't required for this change but aids communication of intent: Replace
pristine
withempty value
.Pristine is an existing term in forms and means "untouched" or "unchanged". Right now keep using a class named
pristine
even if the user has interacted with the input. This can be confusing.Actual change:
We usually try to use class names for styling. This allows easier customization via
classes
API and reduces specificity wars. However, previously styling of the Rating when no rating was given required a combination of class name, sibling and pseudo class selector i.e. knowledge of implementation. This change introduces a single class (labelEmptyValueActive
) which replaces the old selector. It requires more JS for the styling but less for the label-value association since we can now rely on association by hierarchy instead of by ID.