Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Fix unexpected close when releasing click on backdrop #22310

Conversation

danbrud
Copy link
Contributor

@danbrud danbrud commented Aug 22, 2020

Added the code as proposed in that fixes #22151 allowing the dialog to stay open when the click originates on the dialog and ends on the backdrop.

@mui-pr-bot
Copy link

No bundle size changes comparing 45c750f...2cd1454

Generated by 🚫 dangerJS against 2cd1454

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! labels Aug 22, 2020
@oliviertassinari oliviertassinari changed the title [Dialog] keep dialog open when click originates on dialog and ends on backdrop [Dialog] Fix unexpected close when releasing click on backdrop Aug 22, 2020
@oliviertassinari oliviertassinari merged commit df0205e into mui:next Aug 23, 2020
@oliviertassinari
Copy link
Member

@danbrud It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dialog] closes when dragging and releasing mouse button outside dialog
3 participants