Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve /styles vs /core/styles description #16473

Merged
merged 4 commits into from
Oct 1, 2019
Merged

[docs] Improve /styles vs /core/styles description #16473

merged 4 commits into from
Oct 1, 2019

Conversation

bigtone1284
Copy link
Contributor

@bigtone1284 bigtone1284 commented Jul 3, 2019 •
edited by oliviertassinari
Loading

[docs] - change wording of @material-ui/core/styles vs @material-ui/styles portiong of default-theme.md

Help with #15867

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 3, 2019 •
edited
Loading

No bundle size changes comparing 635c601...c01f1ec

Generated by 🚫 dangerJS against c01f1ec

@joshwooding joshwooding added the docs Improvements or additions to the documentation label Jul 8, 2019
@oliviertassinari oliviertassinari self-assigned this Jul 24, 2019
@oliviertassinari oliviertassinari removed their assignment Aug 4, 2019
@oliviertassinari oliviertassinari changed the title [docs] - change wording of @material-ui/core/styles vs @material-ui/s… [docs] Improve /styles vs /core/styles description Sep 29, 2019
@oliviertassinari oliviertassinari force-pushed the issue-15867 branch 2 times, most recently from 9c3fe0d to 8b85c7e Compare September 29, 2019 11:40
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 29, 2019 •
edited
Loading

@mbrookes I have updated the pull request to handle the "description side" of #17387 (comment).
It should be a preliminary change to #17447. Are you happy with the changes?

We have linked the docs page a couple of time (in the GitHub issues), we will likely need to update these links.

@oliviertassinari oliviertassinari self-assigned this Sep 29, 2019
@oliviertassinari oliviertassinari removed their assignment Sep 30, 2019
@oliviertassinari oliviertassinari merged commit a9ca3ca into mui:master Oct 1, 2019
@mbrookes
Copy link
Member

mbrookes commented Oct 1, 2019

Are you happy with the changes?

Sorry, missed this. There's already a similar change made in #17447, so we can unify it there (and fix up the grammar and wording issues introduced in this PR).

@oliviertassinari
Copy link
Member

Agree, rebaseing #17447 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon left review comments

@joshwooding joshwooding joshwooding requested changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bigtone1284 @mui-pr-bot @oliviertassinari @mbrookes @eps1lon @joshwooding