[Divider] Add aria role if it's not implicit #16256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: f69797f...a21f225
|
joshwooding
approved these changes
Jun 16, 2019
joshwooding
reviewed
Jun 16, 2019
| assert.strictEqual(wrapper.find('div').props().role, 'separator'); | ||
| }); | ||
|
|
||
| it('passed roles override', () => { |
There was a problem hiding this comment.
I'm trying to think of a better way to word this.
There was a problem hiding this comment.
Suggested change
| it('passed roles override', () => { | |
| test('passed roles override', () => { |
?
There was a problem hiding this comment.
I guess, or overrides the computed role with a provided one
oliviertassinari
approved these changes
Jun 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #15339 (spotted due to line not being covered)
Setting the role only if a non-default
componentprop is passed follows the behavior in our Button.Rules of aria attributes for hr elements