-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IconButton] Add hover effect to IconButton #10871
[IconButton] Add hover effect to IconButton #10871
Conversation
I'm on the fence about this change in general, but it has an unintended effect on selection controls that needs to be addressed if we're to go ahead with this PR. |
@mbrookes I removed the unintended hover effect from the selection controls. |
Also Table pagination: https://deploy-preview-10871--material-ui-next.netlify.com/demos/tables/#sorting-amp-selecting Admittedly the right margin on the last column looks off in that example (as does the column spacing in the Table component in general), but I'm not sure whether the pagination icons should have the hover effect. (I'm still adjusting to it 😄@oliviertassinari, thoughts? |
@mbrookes The right margin of the buttons looks a bit off in that demo, because that table has >100% width and is horizontally scrollable (PR that fixes that). If you scroll it to the right, everything is fine (and the margin is carefully crafted to match the spec's pictures of the table pagination). I think the hover effect would be great on those buttons, so that the user can see that they are clickable. 👍 |
Oh, so it is. We need to fix the button overflow elsewhere then. |
@SebastianSchmidt I have changed the |
Closes #10869
This pull request is part of #10870.