[material-ui][Select] SelectProps suddenly break by making variant required

[maapteh]

Steps to reproduce

In the latest version this PR https://github.com/mui/material-ui/pull/39137/files breaks the contract by suddenly making the variant prop a required one instead of the previous optional. This is not handy when extending on MUI components where the variant in the base props was optional.

Current behavior

Suddenly getting type errors when doing a patch update of MUI, it should not break

Property 'variant' is missing in type '...snip...' but required in type 'OutlinedSelectProps'.

Expected behavior

Not give compilation errors on components extending MUI Select

Context

When updating from 5.15.7 to 5.15.11 suddenly this error
I can omit the field, but i rather would like MUI to stick to its Base Input Props where variant is typed as optional.

Your environment

[5.15.7 -> 5.15.11] (https://renovatebot.com/diffs/npm/@mui%2fmaterial/5.15.7/5.15.11)

Search keywords: SelectProps variant

[DiegoAndai]

Hey @maapteh, thanks for the report.

Also reported here: #39137 (comment)

I'll look into it this week

[maapteh]

Thank you, i looked but search didnt find anything. I will see if making them optional again will fix my issue.

FYI, this is breaking type change for people using SelectProps 
directly because the variant prop is required now when it wasn't 
before. I guess BaseSelectProps is a suitable replacement 
for most use cases?

This was helpful but not fixing the root cause:)

[maapteh]

I created a fix in the PR attached to this issue report!

[maapteh]

Please look at it @DiegoAndai when you find the time :)

[DiegoAndai]

Hey @maapteh, may I ask you to provide a minimal reproduction? This would help a lot in debugging the issue. A live example would be perfect. This StackBlitz sandbox template may be a good starting point.

[maapteh]

I solved it in #41359 right?

[DiegoAndai]

I'm not sure, I left a comment there

[maapteh]

Ah now i see, but its a union type so i dont see how that would work...
I created the sample at https://stackblitz.com/edit/stackblitz-starters-gfn7kp?file=src%2FApp.tsx

[DiegoAndai]

I created a typescript playground with all the problems I could find, including this one:

• If only the Value type argument is provided, inference on Variant doesn't work due to Allow skipping some generics when calling a function with multiple generics microsoft/TypeScript#10571
• If the Variant type arguments are provided with value "standard" or "filled", but the variant prop is not provided, then the "outlined" variant will be rendered. TS should catch this.
• When trying to wrap the Select, variant is incorrectly required and inference stops working (this issue)

[DiegoAndai]

I'll add the ready to take label to see if we get any contributors with ideas. This is the isolated repro: typescript playground. If you have an idea on how to support wrapping the Select component and avoid the errors in the playground, let's discuss here.