-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dark theme primary and secondary colors #18378
Comments
Are these colors not available in the color palette or are you suggesting we should change the default primary and secondary color? |
As far as I can see, these colors are not in the color palette. Furthermore, the paper and background colors do not respect the spec (elevation is achieved using a white overlay with transparency). |
What do you mean?
What's missing? |
I agree, #18309 describes part of the issue. According to the specs, the background color and paper color is The background for the drawer is As for the colors, the default primary color is You can find more about the dark theme guidelines in the Dark Theme section. |
@rolandjitsu Ok thanks, let's close for #18309 and #18308 that cover two issues with the dark theme. If you see something else specific, please open an issue. Thanks |
@oliviertassinari sure, how about the colors? Is there another issue for this? |
What's the issue with the color? You are free to pick the color you like. |
Ok, we will come back to it for v5, in 1 year. |
Summary 💡
Material UI should follow the latest MD specs for the dark theme colors. And not just colors, this also applies for surfaces and other UI components.
Might be related to #17241.
Examples 🌈
Motivation 🔦
I think it's important to follow the specs closely, makes it easy to align with native mobile apps that use the same MD specs.
The text was updated successfully, but these errors were encountered: