AGE for PG12 #1
Merged
AGE for PG12 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows locally cached contexts to be rebuilt for actions that update the specified underlying graph. Local contexts are tied to their VLE grammar node IDs, which is unique to each command. This ID allows the caching of contexts, which allows their reuse, thus saving the expensive costs of rebuilding a new local context every time, for the same command. Its expected use was within a single command line. This is because the VLE SRF may get invoked many times through the single grammar node's lifetime on that line. However, it was overlooked in static procedures (stored procedures and user created functions) that these grammar nodes might persist longer than the expected life of just one command line. This fix allows them to persist and update along with the graph. Added regression tests.
Fixed the VLE local cache. It had a bug that caused a circular loop in the LRU cache list. This loop would then cause a crash when the cache attempted to purge off old entries. No impact on regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.