Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable eslint 8.31.0 #16

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jbreu
Copy link
Contributor

@jbreu jbreu commented Dec 31, 2022

Motivation

Adds the flowtype plugin explicitly to enable bumping eslint to current version.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Housekeeping (non-code change)

How Has This Been Tested?

  • Jest Unit Test
  • Ran on iOS Simulator
  • Ran on iOS physical device
  • Ran on Android emulator
  • Ran on Android physical device

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@jbreu jbreu force-pushed the dependabot/npm_and_yarn/eslint-8.30.0_jb branch from 4a93bfd to 6d8dbcc Compare December 31, 2022 14:04
@muffix
Copy link
Owner

muffix commented Jan 4, 2023

Hey, this is generally looking great, thanks. I think what's missing to make the yarn install step happy is committing the yarn cache. If you make yarn update the package.json instead of doing it manually (see 4a93bfd), the step should work.

yarn add --dev eslint-plugin-flowtype is what you need, I think.

I added some notes on dependencies in #17.

@jbreu jbreu force-pushed the dependabot/npm_and_yarn/eslint-8.30.0_jb branch from 0450113 to c395f17 Compare January 5, 2023 09:37
@jbreu jbreu force-pushed the dependabot/npm_and_yarn/eslint-8.30.0_jb branch from af979bf to 1f207d8 Compare January 5, 2023 09:57
@jbreu jbreu marked this pull request as ready for review January 5, 2023 10:09
@jbreu
Copy link
Contributor Author

jbreu commented Jan 5, 2023

Thanks for your suggestion. I am entirely new to the JavaScript ecosystem. But it seems it’s proper now

@jbreu jbreu changed the title Dependabot/npm and yarn/eslint 8.30.0 jb Enable eslint 8.31.0 Jan 5, 2023
@muffix muffix added the dependencies Pull requests that update a dependency file label Jan 5, 2023
@muffix muffix self-requested a review January 5, 2023 11:03
Copy link
Owner

@muffix muffix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking great.

@muffix muffix merged commit 98e79d8 into muffix:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants