Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A complete rewrite which addresses DWARF relocations, DWO support, full holistic test against known good golden outputs #22

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

A complete rewrite which addresses DWARF relocations, DWO support, full holistic test against known good golden outputs #22

wants to merge 36 commits into from

Conversation

mtolmacs
Copy link
Owner

No description provided.

mtolmacs added 25 commits December 2, 2023 10:33
@mtolmacs
New tests based on golden wasm and sourcemap
6c7e951 
Currently the address resolution fails, most likely a bug in the mapping
code.

Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Intermediate state of rewrite
3922934 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Refactored but still not compiling
dbec4c2 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Compiling
ddc96a1 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Half compiles
d22afc3 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Relocator type
962b1bd 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
No need to reference
c474ddd 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Everything compiles
2b73d9e 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Small refactors
ec46b2f 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Dwarf handling refactor
c9fd497 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Loader turned into a feature
51efc41 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Refactor
f1d39e9 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Refactors
63a7421 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Path now contains directory
4eec173 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
End sequence fix
cc35082 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Position test adapted, but failing
5543f94 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Column fix for entries
940725d 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
VSCode launch configuration
6f9cd76 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Fixes in entry generation
1aae8a6 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Test asset llvm-dwarfdump output added
0da7ba8 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Bringing entry addresses closer to the golden image
53eb884 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Minimal path resolution issues compared to golden
2414210 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Finally the entry retrival tests pass
878b190 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Introducing thiserror
2c0957e 
Signed-off-by: Márk Tolmács <mark@lazycat.hu>
@mtolmacs
Fix some test- and Result-related issues
a9b9b8d 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.89838% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 61.8%. Comparing base (c7d8074) to head (83bcfe6).

Additional details and impacted files
Files Coverage Δ
wasm2map/src/dwarf/section.rs 100.0% <100.0%> (ø)
wasm2map/src/error.rs 0.0% <0.0%> (-100.0%) ⬇️
wasm2map/src/test.rs 59.0% <89.0%> (-37.1%) ⬇️
wasm2map/src/loader/mmap.rs 45.8% <45.8%> (ø)
wasm2map/src/dwarf/relocate.rs 66.6% <66.6%> (ø)
wasm2map/src/lib.rs 70.0% <69.3%> (-28.5%) ⬇️
wasm2map/src/dwarf/reader.rs 57.7% <57.7%> (ø)

mtolmacs added 4 commits March 6, 2024 14:22
@mtolmacs
Refactored dwarf module
c680e6a 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Rust 1.64 dependency and other fixes
b3f5c7f 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
CI build fix
83bcfe6 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Explicit lifetimes
7fa61c1
@mtolmacs mtolmacs self-assigned this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtolmacs mtolmacs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtolmacs