python3: Use is_cygpty() to detect a terminal; disable readline with … #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll do the same for Python 2, if this is gets accepted. |
…a real Windows console CPython uses isatty() to detect a terminal and change some settings like line buffering and interactive mode. Use is_cygpty() to make this also work under mintty. See https://github.com/Alexpux/MINGW-packages/issues/2645 This also removes the bash script which forced the interactive mode when python3 was started without arguments. This is no longer needed as Python now detects the terminal output and does this automatically. Also use is_cygpty() to detect when not under mintty and disable the readline module there, as using it breaks input of certain characters and leads to errors on shutdown when it tries to save the readline history. (The readline module is not available in the official Python build) See https://github.com/Alexpux/MINGW-packages/issues/2656
49a8f9d to
113887b
Compare
|
rebased on master |
lazka
referenced
this pull request
in lazka/MINGW-packages
Aug 19, 2017
…a real Windows console This is the same patch as https://github.com/Alexpux/MINGW-packages/pull/2675 adjusted to work with Python 2.7
Alexpux
referenced
this pull request
Aug 19, 2017
…a real Windows console (#2806) This is the same patch as https://github.com/Alexpux/MINGW-packages/pull/2675 adjusted to work with Python 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a real Windows console
CPython uses isatty() to detect a terminal and change some settings
like line buffering and interactive mode. Use is_cygpty() to make
this also work under mintty.
See https://github.com/Alexpux/MINGW-packages/issues/2645
This also removes the bash script which forced the interactive mode
when python3 was started without arguments. This is no longer needed as
Python now detects the terminal output and does this automatically.
Also use is_cygpty() to detect when not under mintty and disable the readline
module there, as using it breaks input of certain characters and
leads to errors on shutdown when it tries to save the readline history.
(The readline module is not available in the official Python build)
See https://github.com/Alexpux/MINGW-packages/issues/2656