fix(HttpResponse): support non-configurable status codes #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
commented
Feb 20, 2025
| @@ -1,3 +1,4 @@ | |||
| import { FetchResponse } from '@mswjs/interceptors' | |||
There was a problem hiding this comment.
FetchResponse extends the global Response so it's safe to use both in Node.js and in the browser. I hope the root export of Interceptors doesn't load anything Node.js-specific (it mustn't).
kettanaito
commented
Feb 20, 2025
| @@ -167,7 +168,7 @@ export class HttpResponse extends Response { | |||
| responseInit.headers.set('Content-Length', body.byteLength.toString()) | |||
| } | |||
|
|
|||
| return new HttpResponse(body, responseInit) | |||
| return new HttpResponse(body as ArrayBuffer, responseInit) | |||
There was a problem hiding this comment.
Most likely a Node.js typings hiccup.
Released: v2.7.1 🎉This has been released in v2.7.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, you will be able to do this: