Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3287 ReactNative bump #3296

Merged
merged 2 commits into from
Dec 17, 2020
Merged

#3287 ReactNative bump #3296

merged 2 commits into from
Dec 17, 2020

Conversation

josh-griffin
Copy link
Contributor

Fixes #3287

Change summary

  • Bump RN

Testing

  • App runs

Related areas to think about

N/A

kat-ms
kat-ms previously approved these changes Dec 16, 2020
Copy link
Contributor

@kat-ms kat-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 (and works) good to me

@josh-griffin
Copy link
Contributor Author

❤️ Is it my masses of github extensions which dismiss reviews after I do a commit or is that just how github does stuff now?

🤷 Forcing a merge with admin rights is gonna kick me in the butt soon I bet

@josh-griffin josh-griffin merged commit 610a2f4 into develop Dec 17, 2020
@josh-griffin josh-griffin deleted the #3287-react-native-bump branch December 17, 2020 02:06
@kat-ms
Copy link
Contributor

kat-ms commented Dec 17, 2020

❤️ Is it my masses of github extensions which dismiss reviews after I do a commit or is that just how github does stuff now?

So offended 🙀 ! Actually it looks like it's a Github option doing this isaacs/github#1157 (I don't have access to view the settings so can't verify, but it happened to my PR as well: #3275)

@josh-griffin
Copy link
Contributor Author

Oh cooool I disabled it on this repo, don't tell anyone (also poke me if it's not removed and I messed up!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants