Add msvctricks.exe to replace problematic wine-msvc.bat #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limitation of CMD https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation The maximum length of the string that you can use at the command prompt is 8191 characters. This change is based on the test result of [3] below. 1. echo "%var_of_length_8191%" - Windows CMD: Outputs "The input line is too long." - Wine8.7 CMD: Crashed. 2. echo "%var_of_length_8192%" - Windows CMD: Outputs "". - Wine8.7 CMD: Crashed. 3. echo "!var_of_length_8191!" - Windows CMD: This line is silently ignored and outputs nothing. - Wine8.7 CMD: Outputs all 8191 characters. 4. echo "!var_of_length_8192!" - Windows CMD: Outputs "". - Wine8.7 CMD: Outputs first 8191 characters.
Merged
b9881b6 to
0440cd6
Compare
mstorsjo
reviewed
May 18, 2023
| @@ -137,3 +137,17 @@ for arch in x86 x64 arm arm64; do | |||
| cat msvcenv.sh | sed 's/ARCH=.*/ARCH='$arch/ > bin/$arch/msvcenv.sh | |||
| done | |||
| rm msvcenv.sh | |||
|
|
|||
| host=x64 | |||
There was a problem hiding this comment.
Nice of you to split out the host arch here! FWIW I do have an experimental branch for running on aarch64 (see the branch arm64 in this repo), so for that branch it's easy to pick the right host arch here too.
| if [ -d /proc/$$/fd ]; then | ||
| if ! $HAS_MSVCTRICKS; then | ||
| WINEDEBUG=-all wine64 "$EXE" "${ARGS[@]}" 2> >(sed -e "$unixify_path" >&2) | sed -e "$unixify_path" | ||
| exit $PIPESTATUS |
There was a problem hiding this comment.
Exellent that this can gracefully degrade to the original form of this script, that's much appreciated! (And I see that it's necessary for bootstrapping building the msvctricks executable anyway.)
|
This seems to work fine for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation
The maximum length of the string that you can use at the command prompt is 8191 characters.
Below are tests I have done.
Even I split the argument string into multiple variables with smaller length, wine crashes when total arguments are more than 16350 characters.
The reliable way is to use a native Win32 executable replacing the bat file. Now the arguments can have more than 32700 characters (
CreateProcessaccepts at most 32767 characters).The name
msvctricksfollowswinetricks.