Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsdownload: Add an option to specify target architectures #158

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

huangqinjin
Copy link
Contributor

No description provided.

Copy link
Owner

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@huangqinjin
Copy link
Contributor Author

OK. I will retain Microsoft.VisualStudio.Workload.VCTools and install all architectures by default, To make this PR "No Functional Change" as possible.

@mstorsjo
Copy link
Owner

mstorsjo commented Jan 1, 2025

OK. I will retain Microsoft.VisualStudio.Workload.VCTools and install all architectures by default, To make this PR "No Functional Change" as possible.

Nice, thanks! That makes it easier to proceed. :-)

I also thought we could accept the choices e.g. native (or host) and all, as explicit shorthand choices. (Being able to do --architectures all is a bit easier than having to list all of them.)

@huangqinjin
Copy link
Contributor Author

I also thought we could accept the choices e.g. native (or host) and all, as explicit shorthand choices.

That is a good idea. host is a good shorthand choice. For all, user can just omit the --architecture option.

@huangqinjin huangqinjin marked this pull request as ready for review January 1, 2025 18:27
Copy link
Owner

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@mstorsjo mstorsjo merged commit 79cb30c into mstorsjo:master Jan 1, 2025
8 checks passed
@huangqinjin huangqinjin deleted the target-arch branch January 1, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants