Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsdownload: Fix unable to set --only-host to False #156

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

huangqinjin
Copy link
Contributor

Previously --only-host didn't accept any argument. Now user can explicitly specify yes or no.

$ ./vsdownload.py -h
--only-host [yes|no]  Only download packages that match host arch (default: yes)

Copy link
Owner

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although my Python is a bit too rusty to follow the details of how the custom Action works here.

@mstorsjo mstorsjo merged commit 2cdac04 into mstorsjo:master Jan 1, 2025
4 checks passed
@huangqinjin huangqinjin deleted the fix-only-host-argparse branch January 1, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants