Updates First pass #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2023 11:02
ckittel
approved these changes
Sep 27, 2023
docs/deploy/01-prerequisites.md
Outdated
Comment on lines
32
to
45
| 1. While the following feature(s) are still in _preview_, please enable them in your target subscription. | ||
|
|
||
| 1. [Register the Workload Identity preview feature = `EnableWorkloadIdentityPreview`](https://learn.microsoft.com/azure/aks/workload-identity-deploy-cluster#register-the-enableworkloadidentitypreview-feature-flag) | ||
|
|
||
| ```bash | ||
| az feature register --namespace "Microsoft.ContainerService" -n "EnableWorkloadIdentityPreview" | ||
|
|
||
| # Keep running until all say "Registered." (This may take up to 20 minutes.) | ||
| az feature list -o table --query "[?name=='Microsoft.ContainerService/EnableWorkloadIdentityPreview'].{Name:name,State:properties.state}" | ||
|
|
||
| # When all say "Registered" then re-register the AKS and related resource providers | ||
| az provider register --namespace Microsoft.ContainerService | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can you instead do something like....
1. While the following feature(s) are still in _preview_, please enable them in your target subscription.
_None. This reference implementation currently does not use any preview features._That way it keeps the flow consistent between the various repos and is a place to remind us in the future to add to.
v-fearam
added a commit
to v-fearam/aks-baseline-regulated
that referenced
this pull request
Sep 28, 2023
* Readme update * aks cluster * Readme Change --------- Co-authored-by: Federico Arambarri <v-fearam>
v-fearam
added a commit
to v-fearam/aks-baseline-regulated
that referenced
this pull request
Oct 2, 2023
* Readme update * aks cluster * Readme Change --------- Co-authored-by: Federico Arambarri <v-fearam>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Aks version
2- Workload identity is not on preview any more
3- az cli version