Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (deployment): [jumpbox] remove public key from cloud init file #100

Conversation

ferantivero
Copy link
Contributor

  • remove sensitive identifiers
  • modify steps to ensure proper generation and assignment of the ssh public key

@ferantivero ferantivero changed the title feat (deployment): [jumbox] remove public key from file feat (deployment): [jumpbox] remove public key from cloud init file Sep 13, 2024
@ferantivero ferantivero marked this pull request as ready for review September 14, 2024 02:08
Copy link

@johndowns johndowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few small suggestions to streamline some of the instructions slightly.

docs/deploy/07-aks-jumpbox-users.md Outdated Show resolved Hide resolved
docs/deploy/07-aks-jumpbox-users.md Outdated Show resolved Hide resolved
docs/deploy/07-aks-jumpbox-users.md Outdated Show resolved Hide resolved
docs/deploy/07-aks-jumpbox-users.md Show resolved Hide resolved
Copy link

@johndowns johndowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ferantivero
Copy link
Contributor Author

#sign-off

@johndowns johndowns merged commit e66254d into mspnp:main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants