refactor tests, remove redundant test data files

msonawane · Oct 5, 2018 · edad1c6 · edad1c6
1 parent 4e8e18c
commit edad1c6
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/test/data/commit.json b/test/data/commit.json
diff --git a/test/data/commit.xml b/test/data/commit.xml
diff --git a/test/struct_update_live_test.exs b/test/struct_update_live_test.exs
@@ -15,7 +15,7 @@ defmodule HuiStructUpdateLiveTest do
       x = %Hui.U{doc: doc_map}
 
       Hui.Request.update(url, x)
-      Hui.Request.update(url, File.read!("./test/data/commit.json"))
+      Hui.Request.update(url, "{\"commit\":{}}")
 
       verify_docs_exist(:default, ["tt0083658"])
     end
@@ -64,7 +64,7 @@ defmodule HuiStructUpdateLiveTest do
       x = %Hui.U{doc: [doc_map1, doc_map2]}
 
       Hui.Request.update(url, x)
-      Hui.Request.update(url, File.read!("./test/data/commit.json"))
+      Hui.Request.update(url, "{\"commit\":{}}")
 
       verify_docs_exist(:default, ["tt1316540", "tt1650453"])
     end

diff --git a/test/test_helper.exs b/test/test_helper.exs
@@ -59,7 +59,7 @@ defmodule TestHelpers do
   def delete_verify_doc_deletion(%Hui.URL{} = url, delete_msg, id) when is_binary(delete_msg) do
     # change the following update calls from binary to struct-based later when 'delete', 'commit' ops exist
     Hui.Request.update(url, delete_msg)
-    Hui.Request.update(url, File.read!("./test/data/commit.json"))
+    Hui.Request.update(url, "{\"commit\":{}}")
     ids = if is_list(id), do: Enum.join(id, " OR "), else: id
     resp = Hui.search!(:default, q: "*", fq: ["id:#{ids}"])
     assert resp.body["response"]["numFound"] == 0