bump httpoison to v1.4.0; fix comments re. live tests

msonawane · Nov 6, 2018 · 9522aff · 9522aff
1 parent 3ed6b56
commit 9522aff
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 15 deletions.
diff --git a/mix.exs b/mix.exs
@@ -39,7 +39,7 @@ defmodule Hui.MixProject do
   # Run "mix help deps" to learn about dependencies.
   defp deps do
     [
-      {:httpoison, "~> 1.3.1"},
+      {:httpoison, "~> 1.4.0"},
       {:poison, "~> 4.0.1"},
       {:ex_doc, "~> 0.19", only: :dev, runtime: false},
       {:bypass, "~> 0.9", only: :test},

diff --git a/mix.lock b/mix.lock
@@ -7,8 +7,8 @@
   "earmark": {:hex, :earmark, "1.2.6", "b6da42b3831458d3ecc57314dff3051b080b9b2be88c2e5aa41cd642a5b044ed", [:mix], [], "hexpm"},
   "ex_doc": {:hex, :ex_doc, "0.19.1", "519bb9c19526ca51d326c060cb1778d4a9056b190086a8c6c115828eaccea6cf", [:mix], [{:earmark, "~> 1.1", [hex: :earmark, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.7", [hex: :makeup_elixir, repo: "hexpm", optional: false]}], "hexpm"},
   "excoveralls": {:hex, :excoveralls, "0.10.1", "407d50ac8fc63dfee9175ccb4548e6c5512b5052afa63eedb9cd452a32a91495", [:mix], [{:hackney, "~> 1.13", [hex: :hackney, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm"},
-  "hackney": {:hex, :hackney, "1.14.0", "66e29e78feba52176c3a4213d42b29bdc4baff93a18cfe480f73b04677139dee", [:rebar3], [{:certifi, "2.4.2", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "6.0.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "1.0.1", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "1.0.2", [hex: :mimerl, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "1.1.4", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}], "hexpm"},
-  "httpoison": {:hex, :httpoison, "1.3.1", "7ac607311f5f706b44e8b3fab736d0737f2f62a31910ccd9afe7227b43edb7f0", [:mix], [{:hackney, "~> 1.8", [hex: :hackney, repo: "hexpm", optional: false]}], "hexpm"},
+  "hackney": {:hex, :hackney, "1.14.3", "b5f6f5dcc4f1fba340762738759209e21914516df6be440d85772542d4a5e412", [:rebar3], [{:certifi, "2.4.2", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "6.0.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "1.0.1", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "1.0.2", [hex: :mimerl, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "1.1.4", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}], "hexpm"},
+  "httpoison": {:hex, :httpoison, "1.4.0", "e0b3c2ad6fa573134e42194d13e925acfa8f89d138bc621ffb7b1989e6d22e73", [:mix], [{:hackney, "~> 1.8", [hex: :hackney, repo: "hexpm", optional: false]}], "hexpm"},
   "idna": {:hex, :idna, "6.0.0", "689c46cbcdf3524c44d5f3dde8001f364cd7608a99556d8fbd8239a5798d4c10", [:rebar3], [{:unicode_util_compat, "0.4.1", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm"},
   "jason": {:hex, :jason, "1.1.1", "d3ccb840dfb06f2f90a6d335b536dd074db748b3e7f5b11ab61d239506585eb2", [:mix], [{:decimal, "~> 1.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm"},
   "makeup": {:hex, :makeup, "0.5.1", "966c5c2296da272d42f1de178c1d135e432662eca795d6dc12e5e8787514edf7", [:mix], [{:nimble_parsec, "~> 0.2.2", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm"},

diff --git a/test/search_bang_test.exs b/test/search_bang_test.exs
@@ -15,10 +15,6 @@ defmodule HuiSearchBangTest do
     error_einval: error_einval, error_nxdomain: error_nxdomain}
   end
 
-  describe "http client" do
-
-  end
-
   describe "search (bang)" do
     # tests for Hui.Request.search/3 (bang = true)
 

diff --git a/test/search_live_bang_test.exs b/test/search_live_bang_test.exs
@@ -2,16 +2,16 @@ defmodule HuiSearchLiveBangTest do
   use ExUnit.Case, async: true
 
   # tests using live Solr cores/collections that are
-  # excluded by default, use '--include live' or
-  # change tag value to true to run tests
+  # excluded by default, use '--only live' or
+  # change tag value of :live to true to run tests
   #
   # this required a configured working Solr core/collection
   # see: Configuration for further details
   # 
-  # the tests below use is based on the demo collection
+  # the tests below is based on the demo collection
   # which can be setup quickly
   # http://lucene.apache.org/solr/guide/solr-tutorial.html#solr-tutorial
-  # e.g. http://localhost:8983/solr/gettingstarted
+  # i.e. http://localhost:8983/solr/gettingstarted
   #
 
   describe "search (bang)" do

diff --git a/test/search_live_test.exs b/test/search_live_test.exs
@@ -2,16 +2,16 @@ defmodule HuiSearchLiveTest do
   use ExUnit.Case, async: true
 
   # tests using live Solr cores/collections that are
-  # excluded by default, use '--include live' or
-  # change tag value to true to run tests
+  # excluded by default, use '--only live' or
+  # change tag value of :live to true to run tests
   #
   # this required a configured working Solr core/collection
   # see: Configuration for further details
   # 
-  # the tests below use is based on the demo collection
+  # the tests below is based on the demo collection
   # which can be setup quickly
   # http://lucene.apache.org/solr/guide/solr-tutorial.html#solr-tutorial
-  # e.g. http://localhost:8983/solr/gettingstarted
+  # i.e. http://localhost:8983/solr/gettingstarted
   #
   describe "search" do
     @describetag live: false