fix(project_root): Prefer venv as root over vcs #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, this isn't really that useful. |
|
On second thought, #50 wasn't working on my local linux branch until I re-introduced this change. This is definitely useful to have since python virtual environment naming hints are expected to match the current directory name anyway. |
|
This seems reasonable to me, thanks for reopening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use pyenv and set
flycheck-pycheckers-venv-rootto"~/.pyenv/versions/", you can get a lot more use out of the root project detection features by preferring the virtual environment directory over the vcs one.