Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The action doesn't respect the "ignore" field in config.json #83

Closed
filiphsps opened this issue Jan 17, 2024 · 3 comments · Fixed by #90
Closed

The action doesn't respect the "ignore" field in config.json #83

filiphsps opened this issue Jan 17, 2024 · 3 comments · Fixed by #90
Labels
enhancement New feature or request

Comments

@filiphsps
Copy link

Would be really nice if the action could respect the ignore field in the config.json changeset configuration.

I might be able to look into this personally if it's not just a super simple change; let me know!

@mscharley
Copy link
Owner

mscharley commented Jan 17, 2024

So far this isn't pulling the changesets configuration file, but this sounds like a reasonable first thing to need it for. I don't think it should be too complicated to implement either. I'll try to take a look next week.

FMI: https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#ignore-array-of-packages

It's an array of package names, no globbing support so should be straightforward.

@mscharley
Copy link
Owner

@filiphsps can I get you to test #90 and just make sure it does what you expect it to do? I don't have any repos that are using the ignore option at the moment. You should be able to test the branch by just updating the action to use mscharley/dependency-changesets-action@ignore-changesets-configuration instead of whichever version number you're using currently.

@mscharley
Copy link
Owner

@filiphsps It's been a while, so I'm happy that at a minimum there's no regressions. If you do find that there's some issues with the new ignore functionality then please feel free to log a bug. This has now been released in v1.0.7.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants