Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for specifying distributions as a list of tuples #45

Merged
merged 6 commits into from
Jan 31, 2025
Merged

feat: add support for specifying distributions as a list of tuples #45

merged 6 commits into from
Jan 31, 2025

Conversation

msamsami
Copy link
Owner

@msamsami msamsami commented Jan 31, 2025 •
edited
Loading

  • Added support for specifying the distributions parameter of GeneralNB as a list of tuples of (distribution, columns).
  • Fixed a bug in GeneralNB's fit() method to skip the calculation of self.epsilon_ when X is not numeric.
  • Enhanced test coverage for various formats of the distributions parameter of GeneralNB.
  • Replaced for-loops with pytest.mark.parametrize in unit tests for more efficient testing.
  • Updated the "Introduction" and "Getting Started" sections in README.

@msamsami msamsami added bug Something isn't working enhancement New feature or request labels Jan 31, 2025
@msamsami msamsami self-assigned this Jan 31, 2025
@msamsami msamsami merged commit 18709d4 into main Jan 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@msamsami msamsami

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msamsami