Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add parameter constraints and validations, add _fit_context decorator #44

Merged
merged 4 commits into from
Jan 28, 2025
Merged

feat: add parameter constraints and validations, add _fit_context decorator #44

merged 4 commits into from
Jan 28, 2025

Conversation

msamsami
Copy link
Owner

@msamsami msamsami commented Jan 28, 2025 •
edited
Loading

  • Added parameter constraints for GeneralNB and GaussianWNB according to Scikit-learn version.
  • Improved error messages and validation logic for better error reporting and maintainability.
  • Introduced new unit tests to validate constraints estimators' parameters.
  • Added _fit_context decorator for enhanced context handling.

@msamsami msamsami added bug Something isn't working enhancement New feature or request labels Jan 28, 2025
@msamsami msamsami self-assigned this Jan 28, 2025
@msamsami msamsami changed the title set parameter constraints, improve parameter validations add parameter constraints and validations, add _fit_context decorator Jan 28, 2025
@msamsami msamsami changed the title add parameter constraints and validations, add _fit_context decorator feat: add parameter constraints and validations, add _fit_context decorator Jan 28, 2025
@msamsami msamsami merged commit 4db0269 into main Jan 28, 2025
6 checks passed
@msamsami msamsami deleted the set-parameter-constraints branch January 30, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@msamsami msamsami

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msamsami