Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add var_smoothing parameter to GeneralNB, add pre-support for scikit-learn 1.7 #41

Merged
merged 6 commits into from
Jan 16, 2025
Merged

feat: add var_smoothing parameter to GeneralNB, add pre-support for scikit-learn 1.7 #41

merged 6 commits into from
Jan 16, 2025

Conversation

msamsami
Copy link
Owner

@msamsami msamsami commented Jan 16, 2025 •
edited
Loading

  • Introduce a var_smoothing parameter to the GeneralNB class for improved numerical stability in normal distributions
  • Adjust data validation functions to ensure compatibility with the upcoming Scikit-learn release v1.7
  • Add a benchmark for the Iris dataset, utilizing stratified train-test splitting for more reliable performance evaluation
  • Update benchmark results in the README
  • Rename requirements_dev.txt to requirements-dev.txt for consistency

@msamsami msamsami added the enhancement New feature or request label Jan 16, 2025
@msamsami msamsami self-assigned this Jan 16, 2025
@msamsami msamsami merged commit 504f7b5 into main Jan 16, 2025
7 checks passed
@msamsami msamsami deleted the gaussian-var-smoothing branch January 30, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@msamsami msamsami

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msamsami