Enhance photo size retrieval by combining high-resolution and standard resolutions #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…andard resolutions.
00dc86a to
5424b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR exposes all possible photo resolutions for Android devices. Some Android devices do not expose all resolutions
When we check the sizes coming only from
getSupportedResolutionsthe highest resolution ("4080x3072") is not thereBut when we use the
getSupportedHighResolutionswe can get itSo if we combine and remove the duplicates we can the all sizes possible
Changes
This PR combines the highest and standard photo resolutions
Tested on
Moto G52, Android 13