Asynchronous chunk loading & rendering (using Thread Pool) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
EtlamGit
commented
Aug 5, 2019
- Fix current implementation for asynchronous Chunk loading. Due to a misplaced mutex unlock we only used one loading thread at the time.
- Move Chunk rendering into own (runnable) class and let it render in global thread pool.
- Use separated thread pools for loading and rendering, as Qt queues tasks in order they arrive. This would result in all loading tasks to be executed before anything gets rendered. By using optimal/2 for loading and optimal thread number for rendering we get 1.5x the number of threads than we have CPU cores. In my opinion this is fine, as loading implies disk activity which stalls the task.
Mutex is only necessary for modifying the QCache object. When spanning Mutex also over parsing section, only one Chunk will be loaded and all others are blocked.
const does not mean const here? but it seems to be necessary to stay thread save
change to Singleton Pattern (only one instance makes sense) removes passing around of object and mutex renamed all x,z -> cx,cz to distinguish Chunk coordinates
dedicated ChunkRenderer to render parsed Chunk data into cached image move code for Chunk rendering from Mapview to ChunkRenderer use extra ThreadPool for loading to separate loading/rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.