repair of definition files #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmaxoft
reviewed
May 6, 2019
blockidentifier.cpp
Outdated
| @@ -264,6 +265,7 @@ void BlockIdentifier::parseDefinition(JSONObject *b, BlockInfo *parent, | |||
| name, | |||
| QMessageBox::Cancel, QMessageBox::Cancel); | |||
| } | |||
| #endif | |||
There was a problem hiding this comment.
I think that rather than making this debug-only, the error message should be a bit more descriptive, while keeping it in the release version as well (so that it checks other authors' definition files as well).
How about Failed to add block %1 definition from file %2, because it is already present in the loaded definitions. ? I know it's not exactly what's happening, but it's still of much more help than the old message.
There was a problem hiding this comment.
File name is not available at that code position.
As the old text was only for me, it is obviously not descriptive. I tried a rephrase...
madmaxoft
reviewed
May 6, 2019
blockidentifier.cpp
Outdated
| "Error hashing Block", | ||
| name, | ||
| "Error loading Block definition: " + name, | ||
| "Failed to add Block from definition file, as it might be a duplicate\nor generates the same hash than an already existing Block." , |
There was a problem hiding this comment.
than -> as and I'm happy :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also closes #161
Added an new private method to DefinitionManager to hold all maintenance code regarding definition files. This contains for the moment: