Fix regarding AWS signatures #32 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
json: ...option of http-rb can lead to a AWS signature mismatch, since SearchFlip is using Oj to generate the json for which the signature is calculated, while http-rb is not using Oj. This results in different json being sent over the wire and being used for calculating the signature. More concretely, http-rb is using.to_jsonwhen available and.to_jsone.g. encodes&as\\u0026while Oj is not. To fix thatSearchFlip::HttpClientnow takes thejsonoption, generates the json using Oj and passes it asbodyto http-rb instead.