Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumenter configuration #35

Closed
vitaliel opened this issue Oct 19, 2022 · 1 comment
Closed

Instrumenter configuration #35

vitaliel opened this issue Oct 19, 2022 · 1 comment

Comments

@vitaliel
Copy link

Hi,
Thanks for the gem.

I found in readme:

SearchFlip::Config[:instrumenter] = ActiveSupport::Notifications.notifier

But it fails in rails 6.0 with error:

undefined method `instrument' for #<ActiveSupport::Notifications::Fanout:0x000055673ba78cd8>
.../gems/search_flip-3.7.2/lib/search_flip/criteria.rb:537:in `execute'

The fix I used:

SearchFlip::Config[:instrumenter] = ActiveSupport::Notifications
mrkamel added a commit that referenced this issue Oct 19, 2022
@mrkamel
Fix instrumentation in README #35
4b88d36
mrkamel added a commit that referenced this issue Oct 19, 2022
@mrkamel
Fix instrumentation in README #35 (#36)
ce77308
@mrkamel
Copy link
Owner

mrkamel commented Oct 19, 2022

thx for opening. fixed it in the README.

@mrkamel mrkamel closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaliel @mrkamel