Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextureNode: Improve error message #30215

Merged
merged 1 commit into from
Dec 26, 2024
Merged

TextureNode: Improve error message #30215

merged 1 commit into from
Dec 26, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 26, 2024

Description

Improve error message if value is not a THREE.Texture or null.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06		 339.44
79.06		 +0 B
+0 B
WebGPU 488.29
135.69		 488.35
135.72		 +59 B
+27 B
WebGPU Nodes 487.76
135.57		 487.81
135.6		 +59 B
+27 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11		 465.3
112.11		 +0 B
+0 B
WebGPU 558.08
151.22		 558.14
151.24		 +59 B
+25 B
WebGPU Nodes 514.15
140.96		 514.21
140.99		 +59 B
+26 B

@sunag sunag added this to the r172 milestone Dec 26, 2024
@sunag sunag marked this pull request as ready for review December 26, 2024 19:50
@sunag sunag merged commit 0eaea73 into mrdoob:dev Dec 26, 2024
12 checks passed
@sunag sunag deleted the dev-improve-error-message-1 branch December 26, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag